Add google_kms_key_ring_iam_policy resource and improve iam docs #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosbo
requested review from
paddycarver and
danawillow
and removed request for
danawillow
paddycarver
approved these changes
Dec 6, 2017
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
…hicorp#814) * Add google_kms_key_ring_iam_policy resource and improve iam docs * Delete iam_binding and iam_member specific doc page for key ring
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Sep 27, 2019
Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google_kms_key_ring_iam_policy.The first time I looked at managing IAM policy with Terraform, I was very confused about when to use the policy vs member vs binding resource. I tried to improve our docs by grouping them together on one page and try my best to explain the differences between each.
Please review carefully the proposed documentation change. If y'all agree on it. I will update the IAM docs for the other resource types following the same format.